From 325933f53871c2c328af31578fc5c4ba8f3bc5c1 Mon Sep 17 00:00:00 2001 From: Simon Cambier Date: Sat, 21 Jun 2025 13:59:21 +0200 Subject: [PATCH] removed notice setting --- src/settings/index.ts | 1 - src/settings/settings-http.ts | 12 ------------ src/settings/utils.ts | 1 - src/tools/api-server.ts | 15 ++++++++++----- 4 files changed, 10 insertions(+), 19 deletions(-) diff --git a/src/settings/index.ts b/src/settings/index.ts index f50a6b9..dcd42c6 100644 --- a/src/settings/index.ts +++ b/src/settings/index.ts @@ -111,7 +111,6 @@ export function getDefaultSettings(app: App): LocatorSettings { httpApiEnabled: false, httpApiPort: '51361', - httpApiNotice: true, welcomeMessage: '', verboseLogging: false, diff --git a/src/settings/settings-http.ts b/src/settings/settings-http.ts index b57a736..fc1c3ae 100644 --- a/src/settings/settings-http.ts +++ b/src/settings/settings-http.ts @@ -50,17 +50,5 @@ export function injectSettingsHttp( await saveSettings(plugin) }) }) - - new Setting(containerEl) - .setName('Show a notification when the server starts') - .setDesc( - 'Will display a notification if the server is enabled, at Obsidian startup.' - ) - .addToggle(toggle => - toggle.setValue(settings.httpApiNotice).onChange(async v => { - settings.httpApiNotice = v - await saveSettings(plugin) - }) - ) } } diff --git a/src/settings/utils.ts b/src/settings/utils.ts index 2ad4453..f9ec18c 100644 --- a/src/settings/utils.ts +++ b/src/settings/utils.ts @@ -80,7 +80,6 @@ export interface LocatorSettings extends WeightingSettings { fuzziness: '0' | '1' | '2' httpApiEnabled: boolean httpApiPort: string - httpApiNotice: boolean DANGER_httpHost: string | null } diff --git a/src/tools/api-server.ts b/src/tools/api-server.ts index 761c54e..4d255df 100644 --- a/src/tools/api-server.ts +++ b/src/tools/api-server.ts @@ -48,10 +48,15 @@ export function getServer(plugin: LocatorPlugin) { }, () => { console.log(`Locator - Started HTTP server on port ${port}`) - if (plugin.settings.DANGER_httpHost && plugin.settings.DANGER_httpHost !== 'localhost') { - new Notice(`Locator - Started non-localhost HTTP server at ${plugin.settings.DANGER_httpHost}:${port}`, 120_000) - } - else if (plugin.settings.httpApiNotice) { + if ( + plugin.settings.DANGER_httpHost && + plugin.settings.DANGER_httpHost !== 'localhost' + ) { + new Notice( + `Locator - Started non-localhost HTTP server at ${plugin.settings.DANGER_httpHost}:${port}`, + 120_000 + ) + } else { new Notice(`Locator - Started HTTP server on port ${port}`) } } @@ -67,7 +72,7 @@ export function getServer(plugin: LocatorPlugin) { close() { server.close() console.log(`Locator - Terminated HTTP server`) - if (plugin.settings.httpApiEnabled && plugin.settings.httpApiNotice) { + if (plugin.settings.httpApiEnabled) { new Notice(`Locator - Terminated HTTP server`) } },